[iOS & Android] iOS 1.2.4 & Android 1.7.3

ios/OpenClimb/ViewModels/ClimbingDataManager.swift

@@ -158,7 +158,7 @@ class ClimbingDataManager: ObservableObject {
         }
     }
 
-    private func saveSessions() {
+    internal func saveSessions() {
         if let data = try? encoder.encode(sessions) {
             userDefaults.set(data, forKey: Keys.sessions)
             // Share with widget - convert to widget format
@@ -176,7 +176,7 @@ class ClimbingDataManager: ObservableObject {
         }
     }
 
-    private func saveAttempts() {
+    internal func saveAttempts() {
         if let data = try? encoder.encode(attempts) {
             userDefaults.set(data, forKey: Keys.attempts)
             // Share with widget - convert to widget format
@@ -197,7 +197,7 @@ class ClimbingDataManager: ObservableObject {
         }
     }
 
-    private func saveActiveSession() {
+    internal func saveActiveSession() {
         if let activeSession = activeSession,
             let data = try? encoder.encode(activeSession)
         {
@@ -326,9 +326,6 @@ class ClimbingDataManager: ObservableObject {
         saveSessions()
         DataStateManager.shared.updateDataState()
 
-        successMessage = "Session started successfully"
-        clearMessageAfterDelay()
-
         // MARK: - Start Live Activity for new session
         if let gym = gym(withId: gymId) {
             Task {
@@ -336,9 +333,6 @@ class ClimbingDataManager: ObservableObject {
                     for: newSession, gymName: gym.name)
             }
         }
-
-        // Trigger auto-sync if enabled
-        syncService.triggerAutoSync(dataManager: self)
     }
 
     func endSession(_ sessionId: UUID) {
@@ -356,8 +350,6 @@ class ClimbingDataManager: ObservableObject {
             saveActiveSession()
             saveSessions()
             DataStateManager.shared.updateDataState()
-            successMessage = "Session completed successfully"
-            clearMessageAfterDelay()
 
             // Trigger auto-sync if enabled
             syncService.triggerAutoSync(dataManager: self)
@@ -380,14 +372,14 @@ class ClimbingDataManager: ObservableObject {
 
             saveSessions()
             DataStateManager.shared.updateDataState()
-            successMessage = "Session updated successfully"
-            clearMessageAfterDelay()
 
             // Update Live Activity when session is updated
             updateLiveActivityForActiveSession()
 
-            // Trigger auto-sync if enabled
-            syncService.triggerAutoSync(dataManager: self)
+            // Only trigger sync if session is completed
+            if session.status != .active {
+                syncService.triggerAutoSync(dataManager: self)
+            }
         }
     }
 
@@ -406,8 +398,6 @@ class ClimbingDataManager: ObservableObject {
         sessions.removeAll { $0.id == session.id }
         saveSessions()
         DataStateManager.shared.updateDataState()
-        successMessage = "Session deleted successfully"
-        clearMessageAfterDelay()
 
         // Update Live Activity when session is deleted
         updateLiveActivityForActiveSession()
@@ -435,12 +425,6 @@ class ClimbingDataManager: ObservableObject {
         saveAttempts()
         DataStateManager.shared.updateDataState()
 
-        successMessage = "Attempt logged successfully"
-
-        // Trigger auto-sync if enabled
-        syncService.triggerAutoSync(dataManager: self)
-        clearMessageAfterDelay()
-
         // Update Live Activity when new attempt is added
         updateLiveActivityForActiveSession()
     }
@@ -450,14 +434,9 @@ class ClimbingDataManager: ObservableObject {
             attempts[index] = attempt
             saveAttempts()
             DataStateManager.shared.updateDataState()
-            successMessage = "Attempt updated successfully"
-            clearMessageAfterDelay()
 
             // Update Live Activity when attempt is updated
             updateLiveActivityForActiveSession()
-
-            // Trigger auto-sync if enabled
-            syncService.triggerAutoSync(dataManager: self)
         }
     }
 
@@ -465,14 +444,9 @@ class ClimbingDataManager: ObservableObject {
         attempts.removeAll { $0.id == attempt.id }
         saveAttempts()
         DataStateManager.shared.updateDataState()
-        successMessage = "Attempt deleted successfully"
-        clearMessageAfterDelay()
 
         // Update Live Activity when attempt is deleted
         updateLiveActivityForActiveSession()
-
-        // Trigger auto-sync if enabled
-        syncService.triggerAutoSync(dataManager: self)
     }
 
     func attempts(forSession sessionId: UUID) -> [Attempt] {