Address PR review feedback
- Add SHELL declaration to Makefile for bash compatibility - Add check that release is run from main branch - Use jq instead of grep -oP for JSON parsing in release.yml - Move checkout before git ls-remote in create-release.yml - Add --allow-empty to commit in create-release.yml https://claude.ai/code/session_0158SxS2ATe6PL8zTpsoHRFn
This commit is contained in:
@@ -1,3 +1,4 @@
|
||||
SHELL := /usr/bin/env bash
|
||||
.PHONY: test build package clean
|
||||
|
||||
PLUGIN_NAME := discord-rich-presence
|
||||
@@ -19,6 +20,7 @@ release: test
|
||||
@if [[ ! "${V}" =~ ^[0-9]+\.[0-9]+\.[0-9]+.*$$ ]]; then echo "Usage: make release V=X.X.X"; exit 1; fi
|
||||
go mod tidy
|
||||
@if [ -n "`git status -s`" ]; then echo "\n\nThere are pending changes. Please commit or stash first"; exit 1; fi
|
||||
@if [[ "$$(git branch --show-current)" != "main" ]]; then echo "Releases must be created from the main branch"; exit 1; fi
|
||||
@# Update version in manifest.json
|
||||
@sed -i 's/"version": *"[^"]*"/"version": "${V}"/' manifest.json
|
||||
git add manifest.json
|
||||
|
||||
Reference in New Issue
Block a user