atridad/Discodrome
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 6 Wiki Activity

ci: append git SHA to manifest version in PR builds #14

Merged
deluan merged 2 commits from append-git-sha-to-pr-version into main 2026-02-09 12:28:18 -07:00
Conversation 3 Commits 2 Files Changed 1
+8
deluan commented 2026-02-09 12:00:21 -07:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Adds a build step that patches manifest.json version to X.Y.Z-<short-sha> for PR builds
  • Only runs on pull_request events — push-to-main builds keep the clean release version
  • Makes PR artifacts clearly distinguishable from actual releases

Test plan

  • Verify the "Append git SHA to version" step runs in this PR's own build
  • Download the artifact and confirm manifest.json version is 0.3.0-PR14-<sha>
  • Verify push-to-main builds skip the patching step
## Summary - Adds a build step that patches `manifest.json` version to `X.Y.Z-<short-sha>` for PR builds - Only runs on `pull_request` events — push-to-main builds keep the clean release version - Makes PR artifacts clearly distinguishable from actual releases ## Test plan - [ ] Verify the "Append git SHA to version" step runs in this PR's own build - [ ] Download the artifact and confirm `manifest.json` version is `0.3.0-PR14-<sha>` - [ ] Verify push-to-main builds skip the patching step
gemini-code-assist[bot] commented 2026-02-09 12:00:30 -07:00 (Migrated from github.com)
Copy Link
Copy Source

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

> [!NOTE] > Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.
copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed 2026-02-09 12:01:18 -07:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
github-actions[bot] commented 2026-02-09 12:27:19 -07:00 (Migrated from github.com)
Copy Link
Copy Source

Download the plugin for this PR: discord-rich-presence.zip

Built from 64323ce2f2 on 2026-02-09T19:27:10Z

Download the plugin for this PR: [discord-rich-presence.zip](https://nightly.link/navidrome/discord-rich-presence-plugin/actions/runs/21837571930/discord-rich-presence.zip) Built from 64323ce2f2923b941ad304694f7e9dc9cdfe63a6 on 2026-02-09T19:27:10Z <!-- Sticky Pull Request Comment -->
Sign in to join this conversation.
Reviewers
No Reviewers
copilot-pull-request-reviewer[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
atridad (Atridad Lahiji)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: atridad/Discodrome#14
Delete Branch "append-git-sha-to-pr-version"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?