From 4fe1725567d22e8d13b9b4ae7dc7f8185fbe3fca Mon Sep 17 00:00:00 2001
From: Kirill Kamakin <k.kamakin@protonmail.ch>
Date: Sat, 17 Feb 2024 15:35:10 +0100
Subject: [PATCH] Attempt to fix sign action (#205)

* Set github actions versions in a less restrictive way

* Allow daemon and configuration cache on sign

* Use implicit versions for UI tests as well
---
 .github/workflows/check.yml | 23 +++++++++++++----------
 .github/workflows/sign.yml  | 12 ++++++------
 2 files changed, 19 insertions(+), 16 deletions(-)

diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
index 813f5f9..17b6ad7 100644
--- a/.github/workflows/check.yml
+++ b/.github/workflows/check.yml
@@ -6,22 +6,25 @@ jobs:
   check:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
-      - uses: ashutoshgngwr/validate-fastlane-supply-metadata@d03bc88bf15d7c2ef8682fa057afbf2e4bc85fb4
+      - uses: ashutoshgngwr/validate-fastlane-supply-metadata@v2
         with:
           fastlaneDir: ./fastlane/metadata/android
           usePlayStoreLocales: true
 
-      - uses: actions/setup-java@0ab4596768b603586c0de567f2430c30f5b0d2b0
+      - uses: actions/setup-java@v4
         with:
           distribution: temurin
           java-version: 17
 
       - name: Setup Gradle
-        uses: gradle/gradle-build-action@842c587ad8aa4c68eeba24c396e15af4c2e9f30a
+        uses: gradle/gradle-build-action@v3
+
+      - name: Setup Android SDK
+        uses: android-actions/setup-android@v3
 
       - name: Checks
         run: ./gradlew check :app:koverXmlReportRelease :app:koverVerifyRelease
@@ -32,7 +35,7 @@ jobs:
         run: ./gradlew sonar
 
       - name: Publish test reports
-        uses: mikepenz/action-junit-report@0a8a5ba57593d67b2e45de2c543b438412382b7b
+        uses: mikepenz/action-junit-report@v4
         if: always() # always run even if the previous step fails
         with:
           report_paths: './**/build/test-results/**/TEST-*.xml'
@@ -40,20 +43,20 @@ jobs:
   uiTests:
     runs-on: macos-latest
     steps:
-      - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
-      - uses: actions/setup-java@0ab4596768b603586c0de567f2430c30f5b0d2b0
+      - uses: actions/setup-java@v4
         with:
           distribution: temurin
           java-version: 17
 
       - name: Setup Gradle
-        uses: gradle/gradle-build-action@842c587ad8aa4c68eeba24c396e15af4c2e9f30a
+        uses: gradle/gradle-build-action@v3
 
       - name: Setup Android SDK
-        uses: android-actions/setup-android@13f81365a437096ca29f87b1e7389bf0ea1385ed
+        uses: android-actions/setup-android@v3
 
       - name: Run tests
-        run: ./gradlew allDevicesCheck --no-daemon -Pandroid.testoptions.manageddevices.emulator.gpu="swiftshader_indirect"
+        run: ./gradlew allDevicesCheck -Pandroid.testoptions.manageddevices.emulator.gpu=swiftshader_indirect
diff --git a/.github/workflows/sign.yml b/.github/workflows/sign.yml
index 44cc6f5..0a74472 100644
--- a/.github/workflows/sign.yml
+++ b/.github/workflows/sign.yml
@@ -9,20 +9,20 @@ jobs:
   sign:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
-      - uses: actions/setup-java@0ab4596768b603586c0de567f2430c30f5b0d2b0
+      - uses: actions/setup-java@v4
         with:
           distribution: temurin
           java-version: 17
 
       - name: Setup Gradle
-        uses: gradle/gradle-build-action@842c587ad8aa4c68eeba24c396e15af4c2e9f30a
+        uses: gradle/gradle-build-action@v3
 
       - name: Setup Android SDK
-        uses: android-actions/setup-android@13f81365a437096ca29f87b1e7389bf0ea1385ed
+        uses: android-actions/setup-android@v3
 
       - name: Sign APK
         env:
@@ -38,12 +38,12 @@ jobs:
           echo "storePassword=$MEALIENT_KEY_STORE_PASSWORD" >> keystore.properties
           echo "keyAlias=$MEALIENT_KEY_ALIAS" >> keystore.properties
           echo "keyPassword=$MEALIENT_KEY_PASSWORD" >> keystore.properties
-          ./gradlew build bundle sonar uploadToAppSweepRelease --no-configuration-cache --no-daemon
+          ./gradlew build bundle sonar uploadToAppSweepRelease
           cp app/build/outputs/apk/release/*.apk mealient-release.apk
           cp app/build/outputs/bundle/release/*.aab mealient-release.aab
 
       - name: Upload release build
-        uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32
+        uses: actions/upload-artifact@v4
         with:
           name: Release build
           path: |