Enable lint rules and fix found issues

This commit is contained in:
Kirill Kamakin
2021-11-13 13:42:40 +00:00
parent 2550f31524
commit 740dd12f3b
13 changed files with 10 additions and 11 deletions

View File

@@ -36,6 +36,10 @@ android {
buildFeatures { buildFeatures {
viewBinding true viewBinding true
} }
lintOptions {
disable 'ObsoleteLintCustomCheck'
enable 'ConvertToWebp', 'DuplicateStrings', 'EasterEgg', 'ExpensiveAssertion', 'IconExpectedSize', 'ImplicitSamInstance', 'InvalidPackage', 'KotlinPropertyAccess', 'LambdaLast', 'MinSdkTooLow', 'NegativeMargin', 'NoHardKeywords', 'Registered', 'RequiredSize', 'UnknownNullness', 'WrongThreadInterprocedural'
}
} }
dependencies { dependencies {

View File

@@ -10,7 +10,7 @@
android:fullBackupOnly="true" android:fullBackupOnly="true"
android:icon="@mipmap/ic_launcher" android:icon="@mipmap/ic_launcher"
android:label="@string/app_name" android:label="@string/app_name"
android:roundIcon="@mipmap/ic_launcher_round" android:roundIcon="@mipmap/ic_launcher"
android:supportsRtl="true" android:supportsRtl="true"
android:theme="@style/Theme.Mealie"> android:theme="@style/Theme.Mealie">
<activity <activity

View File

@@ -4,6 +4,4 @@ import com.bumptech.glide.annotation.GlideModule
import com.bumptech.glide.module.AppGlideModule import com.bumptech.glide.module.AppGlideModule
@GlideModule @GlideModule
class MealieGlideModule : AppGlideModule() { class MealieGlideModule : AppGlideModule()
}

View File

Before

Width:  |  Height:  |  Size: 18 KiB

After

Width:  |  Height:  |  Size: 18 KiB

View File

@@ -43,7 +43,7 @@
<com.google.android.material.textfield.TextInputLayout <com.google.android.material.textfield.TextInputLayout
android:id="@+id/url_input_layout" android:id="@+id/url_input_layout"
style="@style/SmallMarginTextInputLayoutStyle" style="@style/SmallMarginTextInputLayoutStyle"
android:hint="@string/fragment_authnetication_input_hint_url" android:hint="@string/fragment_authentication_input_hint_url"
app:layout_constraintBottom_toTopOf="@+id/button" app:layout_constraintBottom_toTopOf="@+id/button"
app:layout_constraintEnd_toEndOf="parent" app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent" app:layout_constraintStart_toStartOf="parent"

View File

@@ -18,6 +18,7 @@
android:id="@+id/image" android:id="@+id/image"
android:layout_width="340dp" android:layout_width="340dp"
android:layout_height="224dp" android:layout_height="224dp"
android:contentDescription="@string/content_description_view_holder_recipe_image"
app:layout_constraintEnd_toEndOf="parent" app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent" app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" app:layout_constraintTop_toTopOf="parent"

View File

@@ -1,5 +0,0 @@
<?xml version="1.0" encoding="utf-8"?>
<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android">
<background android:drawable="@color/white" />
<foreground android:drawable="@mipmap/ic_launcher_foreground" />
</adaptive-icon>

Binary file not shown.

Before

Width:  |  Height:  |  Size: 4.1 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 2.6 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 5.9 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 9.6 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 14 KiB

View File

@@ -2,6 +2,7 @@
<string name="app_name">Mealie</string> <string name="app_name">Mealie</string>
<string name="fragment_authentication_input_hint_email">E-mail</string> <string name="fragment_authentication_input_hint_email">E-mail</string>
<string name="fragment_authentication_input_hint_password">Password</string> <string name="fragment_authentication_input_hint_password">Password</string>
<string name="fragment_authnetication_input_hint_url">Url</string> <string name="fragment_authentication_input_hint_url">Url</string>
<string name="fragment_authentication_button_login">Login</string> <string name="fragment_authentication_button_login">Login</string>
<string name="content_description_view_holder_recipe_image">Picture of the cooked meal</string>
</resources> </resources>