From 817a72b5670e589e4764f993301d93ed272dc989 Mon Sep 17 00:00:00 2001
From: Kirill Kamakin <k.kamakin@protonmail.ch>
Date: Sun, 20 Nov 2022 11:22:20 +0100
Subject: [PATCH] Add round corners to recipe images

---
 app/src/main/res/layout/fragment_recipe_info.xml | 4 +++-
 app/src/main/res/layout/view_holder_recipe.xml   | 6 ++++--
 app/src/main/res/values/dimens.xml               | 2 --
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/app/src/main/res/layout/fragment_recipe_info.xml b/app/src/main/res/layout/fragment_recipe_info.xml
index a044c5f..47d85e1 100644
--- a/app/src/main/res/layout/fragment_recipe_info.xml
+++ b/app/src/main/res/layout/fragment_recipe_info.xml
@@ -34,13 +34,15 @@
 		<com.google.android.material.imageview.ShapeableImageView
 			android:id="@+id/image"
 			android:layout_width="0dp"
-			android:layout_height="@dimen/fragment_recipe_info_image_height"
+			android:layout_height="0dp"
 			android:contentDescription="@string/content_description_fragment_recipe_info_image"
 			android:scaleType="centerCrop"
 			app:layout_constraintBottom_toTopOf="@+id/title"
+			app:layout_constraintDimensionRatio="2:1"
 			app:layout_constraintEnd_toEndOf="parent"
 			app:layout_constraintStart_toStartOf="parent"
 			app:layout_constraintTop_toTopOf="parent"
+			app:shapeAppearance="?shapeAppearanceCornerMedium"
 			tools:srcCompat="@drawable/placeholder_recipe" />
 
 		<TextView
diff --git a/app/src/main/res/layout/view_holder_recipe.xml b/app/src/main/res/layout/view_holder_recipe.xml
index 4d6f908..6574973 100644
--- a/app/src/main/res/layout/view_holder_recipe.xml
+++ b/app/src/main/res/layout/view_holder_recipe.xml
@@ -30,18 +30,20 @@
 
 		<com.google.android.material.imageview.ShapeableImageView
 			android:id="@+id/image"
-			android:layout_width="300dp"
-			android:layout_height="@dimen/height_view_holder_recipe_image"
+			android:layout_width="0dp"
+			android:layout_height="0dp"
 			android:layout_marginStart="15dp"
 			android:layout_marginTop="20dp"
 			android:layout_marginEnd="13dp"
 			android:contentDescription="@string/content_description_view_holder_recipe_image"
 			android:scaleType="centerCrop"
 			app:layout_constraintBottom_toTopOf="@+id/name"
+			app:layout_constraintDimensionRatio="2:1"
 			app:layout_constraintEnd_toEndOf="parent"
 			app:layout_constraintStart_toStartOf="parent"
 			app:layout_constraintTop_toTopOf="parent"
 			app:layout_constraintVertical_chainStyle="packed"
+			app:shapeAppearance="?shapeAppearanceCornerMedium"
 			tools:srcCompat="@drawable/placeholder_recipe" />
 	</androidx.constraintlayout.widget.ConstraintLayout>
 </com.google.android.material.card.MaterialCardView>
\ No newline at end of file
diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
index e482c2b..1f2708e 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -1,6 +1,4 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
 	<dimen name="margin_small">8dp</dimen>
-	<dimen name="height_view_holder_recipe_image">182dp</dimen>
-	<dimen name="fragment_recipe_info_image_height">@dimen/height_view_holder_recipe_image</dimen>
 </resources>
\ No newline at end of file