atridad/Mealient
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Remove Google Analytics and Crashlytics

Browse Source
This commit is contained in:
Kirill Kamakin
2022-11-22 19:50:29 +01:00
parent 2181cdbaa0
commit d62ce1a74e
9 changed files with 0 additions and 157 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/src/main/java/gq/kirmanak/mealient/App.kt
View File

@@ -4,7 +4,6 @@ import android.app.Application
import com.google.android.material.color.DynamicColors
import dagger.hilt.android.HiltAndroidApp
import gq.kirmanak.mealient.architecture.configuration.BuildConfiguration
import gq.kirmanak.mealient.data.analytics.Analytics
import gq.kirmanak.mealient.logging.Logger
import javax.inject.Inject
@@ -17,13 +16,9 @@ class App : Application() {
@Inject
lateinit var buildConfiguration: BuildConfiguration
@Inject
lateinit var analytics: Analytics
override fun onCreate() {
super.onCreate()
logger.v { "onCreate() called" }
analytics.setIsEnabled(!buildConfiguration.isDebug())
DynamicColors.applyToActivitiesIfAvailable(this)
}
}

6
app/src/main/java/gq/kirmanak/mealient/data/analytics/Analytics.kt
View File

@@ -1,6 +0,0 @@
package gq.kirmanak.mealient.data.analytics
interface Analytics {
fun setIsEnabled(enabled: Boolean)
}

21
app/src/main/java/gq/kirmanak/mealient/data/analytics/AnalyticsImpl.kt
View File

@@ -1,21 +0,0 @@
package gq.kirmanak.mealient.data.analytics
import com.google.firebase.analytics.FirebaseAnalytics
import com.google.firebase.crashlytics.FirebaseCrashlytics
import gq.kirmanak.mealient.logging.Logger
import javax.inject.Inject
import javax.inject.Singleton
@Singleton
class AnalyticsImpl @Inject constructor(
private val firebaseAnalytics: FirebaseAnalytics,
private val firebaseCrashlytics: FirebaseCrashlytics,
private val logger: Logger,
) : Analytics {
override fun setIsEnabled(enabled: Boolean) {
logger.v { "setIsEnabled() called with: enabled = $enabled" }
firebaseAnalytics.setAnalyticsCollectionEnabled(enabled)
firebaseCrashlytics.setCrashlyticsCollectionEnabled(enabled)
}
}

18
app/src/main/java/gq/kirmanak/mealient/di/AppModule.kt
View File

@@ -5,16 +5,12 @@ import androidx.datastore.core.DataStore
import androidx.datastore.preferences.core.PreferenceDataStoreFactory
import androidx.datastore.preferences.core.Preferences
import androidx.datastore.preferences.preferencesDataStoreFile
import com.google.firebase.analytics.FirebaseAnalytics
import com.google.firebase.crashlytics.FirebaseCrashlytics
import dagger.Binds
import dagger.Module
import dagger.Provides
import dagger.hilt.InstallIn
import dagger.hilt.android.qualifiers.ApplicationContext
import dagger.hilt.components.SingletonComponent
import gq.kirmanak.mealient.data.analytics.Analytics
import gq.kirmanak.mealient.data.analytics.AnalyticsImpl
import gq.kirmanak.mealient.data.storage.PreferencesStorage
import gq.kirmanak.mealient.data.storage.PreferencesStorageImpl
import javax.inject.Singleton
@@ -28,23 +24,9 @@ interface AppModule {
@Singleton
fun provideDataStore(@ApplicationContext context: Context): DataStore<Preferences> =
PreferenceDataStoreFactory.create { context.preferencesDataStoreFile("settings") }
@Provides
@Singleton
fun provideFirebaseAnalytics(@ApplicationContext context: Context): FirebaseAnalytics =
FirebaseAnalytics.getInstance(context)
@Provides
@Singleton
fun provideFirebaseCrashlytics(): FirebaseCrashlytics =
FirebaseCrashlytics.getInstance()
}
@Binds
@Singleton
fun bindPreferencesStorage(preferencesStorage: PreferencesStorageImpl): PreferencesStorage
@Binds
@Singleton
fun bindAnalytics(analyticsImpl: AnalyticsImpl): Analytics
}

38
app/src/test/java/gq/kirmanak/mealient/data/analytics/AnalyticsImplTest.kt
View File

@@ -1,38 +0,0 @@
package gq.kirmanak.mealient.data.analytics
import com.google.firebase.analytics.FirebaseAnalytics
import com.google.firebase.crashlytics.FirebaseCrashlytics
import gq.kirmanak.mealient.test.BaseUnitTest
import io.mockk.impl.annotations.MockK
import io.mockk.verify
import org.junit.Before
import org.junit.Test
class AnalyticsImplTest : BaseUnitTest() {
@MockK(relaxUnitFun = true)
lateinit var firebaseAnalytics: FirebaseAnalytics
@MockK(relaxUnitFun = true)
lateinit var firebaseCrashlytics: FirebaseCrashlytics
lateinit var subject: Analytics
@Before
override fun setUp() {
super.setUp()
subject = AnalyticsImpl(firebaseAnalytics, firebaseCrashlytics, logger)
}
@Test
fun `when setIsEnabled expect call to analytics`() {
subject.setIsEnabled(true)
verify { firebaseAnalytics.setAnalyticsCollectionEnabled(eq(true)) }
}
@Test
fun `when setIsEnabled expect call to crashlytics`() {
subject.setIsEnabled(true)
verify { firebaseCrashlytics.setCrashlyticsCollectionEnabled(eq(true)) }
}
}