From d1e2d9bf4fcc7ac16629b8e5234193dc654925b7 Mon Sep 17 00:00:00 2001
From: Atridad Lahiji <me@atri.dad>
Date: Tue, 5 Nov 2024 00:42:25 -0600
Subject: [PATCH] Using transactions

---
 lib/himbucks.go | 38 ++++++++++++++++++++++++++------------
 1 file changed, 26 insertions(+), 12 deletions(-)

diff --git a/lib/himbucks.go b/lib/himbucks.go
index 7083e89..2a2aa88 100644
--- a/lib/himbucks.go
+++ b/lib/himbucks.go
@@ -26,26 +26,45 @@ func ProcessMessage(s *discordgo.Session, m *discordgo.MessageCreate) error {
 		return nil
 	}
 
+	// Start transaction for user creation/lookup and himbucks entry
+	tx, err := DBClient.Begin()
+	if err != nil {
+		return fmt.Errorf("failed to start transaction: %w", err)
+	}
+	defer tx.Rollback()
+
 	// Get user from database, create if doesn't exist
 	var userID int
-	err := DBClient.QueryRow("SELECT id FROM users WHERE discord_id = ?", m.Author.ID).Scan(&userID)
+	err = tx.QueryRow("SELECT id FROM users WHERE discord_id = ?", m.Author.ID).Scan(&userID)
 	if err == sql.ErrNoRows {
-		// Store user in database
-		err = StoreUser(m.Author.ID, m.Author.Username)
+		// Store user in database using existing StoreUser function within transaction
+		result, err := tx.Exec(
+			"INSERT INTO users (discord_id, username) VALUES (?, ?)",
+			m.Author.ID, m.Author.Username)
 		if err != nil {
 			return fmt.Errorf("failed to store user: %w", err)
 		}
 
-		// Get the ID of the newly created user
-		err = DBClient.QueryRow("SELECT id FROM users WHERE discord_id = ?", m.Author.ID).Scan(&userID)
+		id, err := result.LastInsertId()
 		if err != nil {
 			return fmt.Errorf("failed to get new user ID: %w", err)
 		}
+		userID = int(id)
+
+		// Immediately create corresponding himbucks entry
+		_, err = tx.Exec(`
+            INSERT INTO himbucks (user_id, guild_id, balance, message_count)
+            VALUES (?, ?, 0, 0)`,
+			userID, m.GuildID)
+		if err != nil {
+			return fmt.Errorf("failed to create initial himbucks entry: %w", err)
+		}
 	} else if err != nil {
 		return fmt.Errorf("failed to query user: %w", err)
 	}
 
-	_, err = DBClient.Exec(`
+	// For existing users, ensure himbucks entry exists
+	_, err = tx.Exec(`
         INSERT INTO himbucks (user_id, guild_id, balance, message_count)
         VALUES (?, ?, 0, 0)
         ON CONFLICT (user_id, guild_id) DO NOTHING`,
@@ -54,12 +73,7 @@ func ProcessMessage(s *discordgo.Session, m *discordgo.MessageCreate) error {
 		return fmt.Errorf("failed to create himbucks entry: %w", err)
 	}
 
-	tx, err := DBClient.Begin()
-	if err != nil {
-		return fmt.Errorf("failed to start transaction: %w", err)
-	}
-	defer tx.Rollback()
-
+	// Process the message count and rewards
 	var messageCount int
 	var lastEarnedAt sql.NullTime